Skip to content

Added missing method to access raw scan advertisement data #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bitbank2
Copy link

The current ArduinoBLE library does not include a way to access the raw scan advertisement data even though it is received. I added a simple method to BLEDevice to accomplish this. Please consider merging this with the master branch.

@per1234 per1234 added the type: enhancement Proposed improvement label Feb 28, 2021
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Laurence Bank seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bitbank2
Copy link
Author

bitbank2 commented Apr 9, 2021

The "Please agree to the CLA" page seems to be non functional for me and I've already signed it before. My email address is associated with this account ([email protected]), so I'm not sure why it doesn't recognize me. Can you help?

@bitbank2
Copy link
Author

Today it worked and I signed the agreement. Waiting for it to see that I signed it...

@bitbank2
Copy link
Author

This PR seems to be stuck. I signed the CLA and it acknowledged this, yet is still stuck.

@polldo
Copy link
Contributor

polldo commented May 27, 2021

Hi @bitbank2 , thanks for your help.
I've addressed this issue here #183 starting from a similar PR.
Your feedbacks are really welcome!

@per1234
Copy link
Contributor

per1234 commented May 13, 2022

Thanks so much for your pull request @bitbank2!

I believe this has been superseded by #183 so I'll go ahead and close it.

I apologize for any inconvenience resulting from Arduino's fumbled handling of supporting contributors in regards to CLA check failures.

@per1234 per1234 closed this May 13, 2022
@per1234 per1234 added conclusion: duplicate Has already been submitted topic: code Related to content of the project itself labels May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants